Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Enable linux code checker #35084

Merged

Conversation

congqixia
Copy link
Contributor

See also #34483

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Jul 29, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 29, 2024
@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. area/compilation and removed size/XL Denotes a PR that changes 500-999 lines. labels Jul 29, 2024
Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
Copy link
Contributor

mergify bot commented Jul 30, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia congqixia force-pushed the enhance/enable_linx_code_checker branch from d809b7e to c013308 Compare July 30, 2024 01:08
@sre-ci-robot sre-ci-robot added area/dependency Pull requests that update a dependency file area/test sig/testing labels Jul 30, 2024
Copy link
Contributor

mergify bot commented Jul 30, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia congqixia force-pushed the enhance/enable_linx_code_checker branch from c013308 to d824a27 Compare July 30, 2024 02:18
Signed-off-by: Congqi Xia <[email protected]>
@MrPresent-Han
Copy link
Contributor

/lgtm

Copy link
Contributor

mergify bot commented Jul 30, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor

/lgtm

@weiliu1031
Copy link
Contributor

/run-cpu-e2e

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot removed the lgtm label Jul 30, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@congqixia
Copy link
Contributor Author

manual adding label due to mergify configuration updated

@congqixia congqixia added ci-passed manual-pass manually set pass before ci-passed labeled labels Jul 30, 2024
@sre-ci-robot sre-ci-robot merged commit de8a266 into milvus-io:master Jul 30, 2024
11 of 12 checks passed
congqixia added a commit to congqixia/milvus that referenced this pull request Jul 30, 2024
sre-ci-robot pushed a commit that referenced this pull request Jul 30, 2024
sumitd2 pushed a commit to sumitd2/milvus that referenced this pull request Aug 6, 2024
See also milvus-io#34483

---------

Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
sumitd2 pushed a commit to sumitd2/milvus that referenced this pull request Aug 6, 2024
weiliu1031 pushed a commit to weiliu1031/milvus that referenced this pull request Aug 19, 2024
weiliu1031 pushed a commit to weiliu1031/milvus that referenced this pull request Aug 19, 2024
sre-ci-robot pushed a commit that referenced this pull request Aug 21, 2024
@congqixia congqixia deleted the enhance/enable_linx_code_checker branch September 9, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation area/dependency Pull requests that update a dependency file area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled sig/testing size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants